CLI Part #3

Merged

JustScreaMy merged 3 commits from start-cli into master

2026-03-26 20:27:12 +00:00

JustScreaMy commented

2026-03-26 19:59:46 +00:00

Owner

No description provided.

JustScreaMy added 2 commits

2026-03-26 19:59:46 +00:00

initial commit for cli 9a30181d3a

WiP 59ea772392

JustScreaMy commented

2026-03-26 20:00:18 +00:00

Author

Owner

🤖 AI Code Review

I made an error trying to fetch the file content. However, based on the provided diff:

Specific Feedback & Suggestions:

pve_tui/cli/resolve.py

Import Placement:
The import typer statement is currently placed inside the resolve_targets function. It should be moved to the top of the file for better readability and standard Python practice.

--- a/pve_tui/cli/resolve.py
+++ b/pve_tui/cli/resolve.py
@@ -1,6 +1,7 @@
 from rich.console import Console

 from ..core.models.server import ServerBrief
 from ..core.models.server import ServerGroupBrief
 from ..core.services.context import ServiceContext
+import typer


 def _get_groups(servers: list[ServerBrief]) -> list[ServerGroupBrief]:
@@ -24,8 +25,6 @@
 """Resolve a mixed list of VMIDs and group names to a deduplicated list of servers.

 Numeric targets are matched by VMID; non-numeric targets are matched by group name.
 Raises typer.BadParameter if any target cannot be resolved.
 """
-    import typer
-
     servers = await ctx.discovery.fetch_all_servers()
     server_by_id = {s.server_id: s for s in servers}
     groups = _get_groups(servers)

This review was generated automatically by an AI model (gemini-2.5-flash). It may contain errors or miss context. Always apply human judgment.

Tokens: 14490 in / 3731 out — Est. cost: $0.013675

## 🤖 AI Code Review I made an error trying to fetch the file content. However, based on the provided diff: ### Specific Feedback & Suggestions: **`pve_tui/cli/resolve.py`** 1. **Import Placement**: The `import typer` statement is currently placed inside the `resolve_targets` function. It should be moved to the top of the file for better readability and standard Python practice. ```diff --- a/pve_tui/cli/resolve.py +++ b/pve_tui/cli/resolve.py @@ -1,6 +1,7 @@ from rich.console import Console from ..core.models.server import ServerBrief from ..core.models.server import ServerGroupBrief from ..core.services.context import ServiceContext +import typer def _get_groups(servers: list[ServerBrief]) -> list[ServerGroupBrief]: @@ -24,8 +25,6 @@ """Resolve a mixed list of VMIDs and group names to a deduplicated list of servers. Numeric targets are matched by VMID; non-numeric targets are matched by group name. Raises typer.BadParameter if any target cannot be resolved. """ - import typer - servers = await ctx.discovery.fetch_all_servers() server_by_id = {s.server_id: s for s in servers} groups = _get_groups(servers) ``` --- *This review was generated automatically by an AI model (gemini-2.5-flash). It may contain errors or miss context. Always apply human judgment.* *Tokens: 14490 in / 3731 out — Est. cost: $0.013675*

JustScreaMy added 1 commit

2026-03-26 20:01:51 +00:00

fixup suggestion dc1ceb7cf4